[TrimmableTypeMap] Inline activation ctor in UCO wrappers#11089
Closed
simonrozsival wants to merge 1 commit intodev/simonrozsival/fix-uco-activation-parityfrom
Closed
[TrimmableTypeMap] Inline activation ctor in UCO wrappers#11089simonrozsival wants to merge 1 commit intodev/simonrozsival/fix-uco-activation-parityfrom
simonrozsival wants to merge 1 commit intodev/simonrozsival/fix-uco-activation-parityfrom
Conversation
This was referenced Apr 8, 2026
c624b1d to
f01e508
Compare
- UCO constructors directly call activation ctor (no ActivateInstance indirection) - WithinNewObjectScope guard prevents double peer creation - No-op UCO for open generic type definitions - ControlFlowBuilder support in PEAssemblyBuilder - Remove TrimmableNativeRegistration wrapper and ActivateInstance Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
b676200 to
c19872c
Compare
Member
Author
|
Folded into #11094 so the guard and inline-activation changes are reviewed together in one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline UCO activation
Depends on: #11094 (
WithinNewObjectScopeguard)Scope
TrimmableTypeMap.ActivateInstance()from the runtime pathnctor_*_ucowrappersPEAssemblyBuilder.EmitBody(..., useBranches: true)plumbing needed by the emitted ILNot in this PR
WithinNewObjectScopeguard itself — that lives in [TrimmableTypeMap] Fix UCO constructor activations #11094Generated IL shape